[wp-trac] [WordPress Trac] #22512: WP_Image_Editor - image_resize_dimensions called twice, cropping position

WordPress Trac noreply at wordpress.org
Tue Nov 20 02:30:03 UTC 2012


#22512: WP_Image_Editor - image_resize_dimensions called twice, cropping position
-----------------------------+--------------------------
 Reporter:  alexvorn2        |       Type:  defect (bug)
   Status:  new              |   Priority:  normal
Milestone:  Awaiting Review  |  Component:  General
  Version:                   |   Severity:  normal
 Keywords:                   |
-----------------------------+--------------------------
 '''Problem 1:''' - Prevent calling the image_resize_dimensions function
 twice.

 When we need to resize an image we need first check if the resized image
 file name exists and after that - resize.

 For checking if the resized image exist we need the new width and height
 that we can get from image_resize_dimensions(),

 and after that we resize, using the resize function from the class, in the
 function we have image_resize_dimensions function too, so it happens that
 it is called twice...

 '''Problem 2''' - Cropping image position

 For example we cropped an image with a 'top' position, (default crop is
 center position)
 and after that if we will want a new position like center or bottom, or
 right/left we should delete the old cropped image before cropping the new
 one.

 '''Problem 3''' no documentation, no examples
 this new class was integrated to fast, and the old functions were
 deprecated in the favor of this class, why? why not to deprecate in future
 versions?
 No documentation and examples in codex, so the theme developers should
 found but itself how to integrates this new option of resizing images
 before the new version of WordPress to come out (release).

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22512>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list