[wp-trac] [WordPress Trac] #22400: Remove all, or at least most, uses of extract() within WordPress

WordPress Trac noreply at wordpress.org
Sat Nov 10 01:17:41 UTC 2012


#22400: Remove all, or at least most, uses of extract() within WordPress
--------------------------+------------------------------
 Reporter:  Viper007Bond  |       Owner:
     Type:  enhancement   |      Status:  new
 Priority:  lowest        |   Milestone:  Awaiting Review
Component:  General       |     Version:  3.4.2
 Severity:  minor         |  Resolution:
 Keywords:                |
--------------------------+------------------------------

Comment (by rmccue):

 +1, it's a pain to trace this variables back at times, and it messes with
 autocompletion in editors with that ability.

 Replying to [comment:4 ericmann]:
 > I agree.  Additionally, we're finally making huge strides in keeping
 core documented. It's easy to mark up a function signature with phpDoc and
 identify the `$args` array that gets passed in.  Seeing a variable later
 that's not in this signature definition is confusing at best and
 misleading at worst.

 Side-note: the [http://www.php-fig.org/ PHP-FIG] has been
 [https://groups.google.com/d/topic/php-fig/o4ko1XsGtAw/discussion
 discussing] how to document these sorts of parameters. It's a huge
 discussion, and nothing's finalised yet, but once that is finalised we
 should look at beginning to use it (along with an updated documentation
 tool).

 Replying to [comment:3 MikeHansenMe]:
 > /wp-includes/SimplePie/Enclosure.php

 I'm happy to say that's in a method that will be deprecated. :)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22400#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list