[wp-trac] [WordPress Trac] #15737: Blogger Importer notices

WordPress Trac wp-trac at lists.automattic.com
Fri May 18 09:18:38 UTC 2012


#15737: Blogger Importer notices
------------------------------------+----------------------------
 Reporter:  joostdevalk             |       Owner:  joostdevalk
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  WordPress.org
Component:  Import                  |     Version:  3.1
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+----------------------------

Comment (by Workshopshed):

 Hi Joost,
 I've got a working version of the importer based on Otto's OAuth fork. I
 also spotted the notices about unassigned variables.

 I'm trying to understand part of your patch, I've changed get_user_options
 function to use get_users as follows.


 {{{
 function get_user_options($current) {
 global $importer_users;
 if ( ! isset( $importer_users ) )
         $importer_users = (array) get_users();  //Function:
 get_users_of_blog() Deprecated in version 3.1. Use get_users() instead.

         $options = '';

         foreach ( $importer_users as $user ) {
                 $sel = ( $user->ID == $current ) ? " selected='selected'"
 : '';
                 $options .= "<option
 value='$user->ID'$sel>$user->display_name</option>";
         }
         return $options;
 }

 }}}

 You've also change $user->ID to $user->data->ID, is that still relavent
 now that the function has been swapped out?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/15737#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list