[wp-trac] [WordPress Trac] #19861: $wpdb->prepare() fails with localized floats

WordPress Trac wp-trac at lists.automattic.com
Mon May 7 14:12:34 UTC 2012


#19861: $wpdb->prepare() fails with localized floats
--------------------------+------------------------------
 Reporter:  laotse        |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Database      |     Version:  3.3.1
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+------------------------------
Changes (by coffee2code):

 * version:   => 3.3.1


Comment:

 You should also:

 * Attach the .diff directly (and not compressed)
 * If using git to generate the diff, (from the WP root) do: `git diff
 --no-prefix > 19861.diff`
 * Ideally, as done in my previous example, use the ticket number as part
 of the diff filename

 I would also recommend separating out your debugging-related changes and
 attaching that code/diff separately.

 And based on the nature of the changes you're making, you're really going
 to want to include some unit tests if you hope to get some traction (see
 http://unit-test.trac.wordpress.org/). Even if not a true unit test patch,
 at least some example code to demonstrate the issues as things stand now,
 and which would work once your patch is applied.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19861#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list