[wp-trac] [WordPress Trac] #20603: Warning error occurs on the default parameter of "admin-head-callback" in add_theme_support.

WordPress Trac wp-trac at lists.automattic.com
Thu May 3 13:28:49 UTC 2012


#20603: Warning error occurs on the default parameter of "admin-head-callback" in
add_theme_support.
--------------------------+-----------------------
 Reporter:  jim912        |       Owner:  nacin
     Type:  defect (bug)  |      Status:  reopened
 Priority:  high          |   Milestone:  3.4
Component:  Themes        |     Version:  3.4
 Severity:  major         |  Resolution:
 Keywords:  has-patch     |
--------------------------+-----------------------

Comment (by nacin):

 The best change is revert the changes to wp-includes/theme.php and make
 admin-head-callback optional. There's really no reason to not make it
 optional — the admin preview (image div) callback is optional; the
 argument enforces admin_head CSS for a header when it may not be needed.

 The main issue is that otherwise we would have to enforce admin-head-
 callback as the only required argument for both custom headers and custom
 backgrounds. This forces us to do some funky things in the just-in-time
 function and I don't find it to be necessary for what should be optional
 CSS.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20603#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list