[wp-trac] [WordPress Trac] #19910: Appearance Improvements: Theme Customization Frame

WordPress Trac wp-trac at lists.automattic.com
Wed Mar 21 18:42:59 UTC 2012


#19910: Appearance Improvements: Theme Customization Frame
----------------------------+--------------------------
 Reporter:  koopersmith     |       Owner:  koopersmith
     Type:  task (blessed)  |      Status:  accepted
 Priority:  normal          |   Milestone:  3.4
Component:  Themes          |     Version:  3.3.1
 Severity:  normal          |  Resolution:
 Keywords:                  |
----------------------------+--------------------------

Comment (by azaozz):

 Replying to [comment:55 koopersmith]:
 > Note: I reviewed [20179] with Nacin, Ryan, and Mark in person at SXSW.
 Feedback welcome.

 Some quick feedback:

 - Moving the settings for plupload to a separate function is nice, well
 done.
 - Having that function defined every time a visitor or a bot hits the
 front-end is not (this is a part of a bigger problem that eventually will
 have to be solved: there are a lot of functions in wp-includes that cannot
 be used on the front-end unless the user is logged in and have certain
 privileges. 99%+ of the hits on the front-end fall into this category).
 - Not sure there is a need for wp-plupload.js at all, at least not in it's
 current form. Why is it needed to proxy the settings for an external
 library? Perhaps it would be clearer if wp_plupload_default_settings()
 actually contained the simple function needed to initialize plupload
 instead of needing yet another JS file.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19910#comment:22>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list