[wp-trac] [WordPress Trac] #20219: GET - Too many redirects

[WordPress Trac]

#20219: GET - Too many redirects
--------------------------+------------------------------
 Reporter:  Workshopshed  |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  HTTP          |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------------------

Comment (by dd32):

 (Note for simplification: safe_mode references below apply to safe_mode OR
 it's little brother, open_basedir, which has the same effect upon cURL for
 no good reason - I believe you'll have open_basedir in use)

 Thanks for the extra info, I can duplicate it with safe_mode enabled, as
 in that cause, cURL doesn't follow redirections at all, causing
 `$theResponse` to be empty.

 The line you've tracked it to above is correct, There's a logic error
 there, or it's not taking into account safe_mode in the mix somehow.

 Some quick testing between safe mode enabled, disabled, and GET/HEAD
 requests hasn't lead me to stumble over the right logical option to use
 here though. The proposed patch allows for significantly more redirections
 than anticipated on non-safe_mode environments, It shouldn't be entering
 that if block at all under ideal situations. meaning either the conditions
 need to be altered, or the block further down the function related to
 #11305 needs to be brought up.

 While I'm looking at the method in question.. `$args` is used directly a
 few times where `$r` (the parsed args) should be used.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20219#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software