[wp-trac] [WordPress Trac] #19810: Autocomplete for users and sites in Network admin

[WordPress Trac]

#19810: Autocomplete for users and sites in Network admin
------------------------------+------------------
 Reporter:  markjaquith       |       Owner:
     Type:  task (blessed)    |      Status:  new
 Priority:  high              |   Milestone:  3.4
Component:  Multisite         |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+------------------

Comment (by westi):

 Replying to [comment:54 Japh]:
 > Waiting on commit. If this isn't ready for commit, can someone please
 provide feedback so we can get it ready?

 This looks pretty good (I've not tested the functionality just read the
 code)

 Some feedback:

 You have lots of code like this:

 {{{
 if ( is_multisite()
                 && current_user_can( 'promote_users' )
                 && ! wp_is_large_network( 'users' )
                 && is_super_admin()
         ) {
 }}}

 If it is in a file in `wp-admin/network` then I don't see why we need to
 check `is_multisite()` or `is_super_admin()` and removing those checks
 will simplify the code and then the if can be on a single line.

 I think `wp_ajax_autocomplete_site` should probably have a nonce check so
 as to avoid any chance of someone DOSing a site when a logged in Super
 Admin visits a page elsewhere.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19810#comment:55>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software