[wp-trac] [WordPress Trac] #20187: PemFTP Failing to Fall Back to Pure PHP Implementation

[WordPress Trac]

#20187: PemFTP Failing to Fall Back to Pure PHP Implementation
------------------------------------+------------------------------
 Reporter:  merty                   |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  External Libraries      |     Version:  2.3.1
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |
------------------------------------+------------------------------

Comment (by merty):

 Technically there is no difference but extension_loaded('sockets') looks
 like a better coding practice to me.

 The actual issue, however, is not detecting the availability of
 php_sockets. The issue is, wherever dl() is not available, the if-check
 silently fails and therefore it does not set $mod_sockets's value to FALSE
 even though it should.

 dl() is deprecated in PHP 5.3 and completely removed in PHP6. Either we
 can completely remove the part where it tries to load the extension in the
 runtime, or we can just check the availability of dl() and prevent
 unexpected behaviors.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20187#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software