[wp-trac] [WordPress Trac] #21233: Twenty Twelve: Make title truly pluggable

WordPress Trac wp-trac at lists.automattic.com
Tue Jul 24 09:30:25 UTC 2012


#21233: Twenty Twelve: Make title truly pluggable
---------------------------+---------------------------
 Reporter:  obenland       |       Owner:  lancewillett
     Type:  defect (bug)   |      Status:  reopened
 Priority:  normal         |   Milestone:  3.5
Component:  Bundled Theme  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |
---------------------------+---------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:10 obenland]:
 > Great catch, Sergey! The patch would be a quick fix, but wouldn't it
 make more sense to remove `bloginfo_rss('name');` from the feed title?

 Sounds good, but I'm not sure about possible back compat repercussions for
 themes and plugins which already take into account that site title is
 hardcoded.


 > We could add a filter to `'wp_title_rss'` or `'get_wp_title_rss'`
 instead and check if the title is empty, before adding the blog name.

 Adding the blog name to empty titles only would mean that it will no
 longer be displayed for category feeds. I guess we should add it if it's
 not already present (while keeping the whole title filterable).

 BTW, category and tag feed titles are also broken in current trunk:
 {{{
 <title>WordPress Trunk &#187; helloWordPress Trunk</title>
 }}}
 Removing the prepended site title wouldn't fix the order, so
 [attachment:21233.3.diff] might still be needed, unless we want to
 reimplement some of `wp_title()` or try to filter out the separator.

 > Clearly not part of this ticket, but way more sustainable than coding
 around it, IMO.

 I've created #21366 for removing the hardcoded site title.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21233#comment:11>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list