[wp-trac] [WordPress Trac] #21325: Pages, Posts, Comments Screens - Prompts for Screen Readers

WordPress Trac wp-trac at lists.automattic.com
Sat Jul 21 16:08:15 UTC 2012


#21325: Pages, Posts, Comments Screens - Prompts for Screen Readers
----------------------------+--------------------
 Reporter:  grahamarmfield  |       Owner:
     Type:  enhancement     |      Status:  new
 Priority:  normal          |   Milestone:  3.5
Component:  Accessibility   |     Version:  3.4.1
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |
----------------------------+--------------------

Comment (by MikeLittle):

 Replying to [comment:3 nacin]:
 > Column headers are printed twice, which means we'd end up with duplicate
 IDs here.
 >

 Doh! Forgot that. I shouldn't code in the early hours!

 > What if we hooked directly into the print_column_headers() list table
 method and always overrode the checkbox column? [attachment:21325.diff]
 >
 > Existing 'cb' => '<input type="checkbox" />' can also become 'cb' =>
 true or 'cb' => false with this change. Unless someone is manually looping
 through get_column_headers() and doing their own printing, there'd be no
 side effect.
 >

 That makes sense.

 > The one issue is that "Select all" might need to be disambiguated for
 localization reasons. "Select all" for posts might translate differently
 than "Select all" for themes, for example. The other option would be to
 consider the context to be selecting all "rows" or "checkboxes," in which
 case, we're fine. It looks like we already use "Select All" elsewhere,
 without context, on update-core.php and elsewhere.


 I think the latter case makes sense, especially as you say, it is used
 elsewhere without context.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21325#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list