[wp-trac] [WordPress Trac] #21238: Twenty Twelve: Sticky badge on single view

[WordPress Trac]

#21238: Twenty Twelve: Sticky badge on single view
---------------------------+---------------------------
 Reporter:  obenland       |       Owner:  lancewillett
     Type:  defect (bug)   |      Status:  closed
 Priority:  normal         |   Milestone:  3.5
Component:  Bundled Theme  |     Version:
 Severity:  normal         |  Resolution:  fixed
 Keywords:  has-patch      |
---------------------------+---------------------------
Changes (by lancewillett):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:8 nacin]:
 > I don't really like [21263]. <article> uses post_class() which means it
 will receive the .sticky class if `is_sticky() && is_home() && !
 is_paged()`.

 Chatted about this in #wordpress-dev IRC channel today, and agreed on
 keeping the conditional here as the solution isn't just a style hook where
 the post_class would be sufficient.

 {{{
 nacin: lancewillett: let me know if my comment on #21238 doesn't make
 sense
 nacin: lancewillett: looking at the code, it doesn't look like it makes
 sense
 lancewillett: I don't think we can use a post_class value to hide the
 extra markup
 nacin: I thought the conditional was about styling, not about an extra
 piece of markup.
 lancewillett: Some kind of logic is needed to add it in
 lancewillett: Right, exactly
 }}}

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21238#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software