[wp-trac] [WordPress Trac] #21749: Wrong URL for theme screenshot

WordPress Trac wp-trac at lists.automattic.com
Fri Aug 31 13:25:24 UTC 2012


#21749: Wrong URL for theme screenshot
--------------------------+--------------------
 Reporter:  pavelevap     |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.4.2
Component:  Themes        |     Version:  3.4.1
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+--------------------
Changes (by SergeyBiryukov):

 * keywords:   => has-patch


Comment:

 The space is stripped by `esc_url()`, since the space is not encoded:
 [[BR]]
 http://core.trac.wordpress.org/browser/tags/3.4.1/wp-admin/includes/class-
 wp-themes-list-table.php#L156

 In 3.3, the screenshot was output directly: [[BR]]
 http://core.trac.wordpress.org/browser/tags/3.3.3/wp-admin/includes/class-
 wp-themes-list-table.php#L160

 I guess `get_*_directory_uri()` should return encoded results.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21749#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list