[wp-trac] [WordPress Trac] #21692: jQuery Color 2.1.0 (update)

WordPress Trac wp-trac at lists.automattic.com
Tue Aug 28 17:47:59 UTC 2012


#21692: jQuery Color 2.1.0 (update)
--------------------------------+-----------------------
 Reporter:  ramoonus            |       Owner:  nacin
     Type:  enhancement         |      Status:  reopened
 Priority:  normal              |   Milestone:  3.5
Component:  External Libraries  |     Version:
 Severity:  normal              |  Resolution:
 Keywords:  has-patch           |
--------------------------------+-----------------------

Comment (by nacin):

 This was added when alerts used to have a color fade. See [6582] for when
 we transitioned from FAT to jQuery Color Animations. At the time, it
 should have been added as a dependency to 'common', just as it was a
 dependency for 'listman'.

 We no longer have any animations in common.js as we no longer have fades
 in our alerts (removed in 2.9). We do however still animate colors when
 approving/unapproving/trashing/etc a comment, which is why we need it for
 wp-lists.

 We only actually use the dimming aspects of wp-lists inside edit-comments,
 but someone else using and extending wp-lists (and, I really do apologize
 to them) might be. By removing the global enqueue, we're still saving some
 bytes, so let's move to wp-lists instead of edit-comments.

 Anyone using color animations in the admin will lose them if they are not
 marking jquery-color as a dependency themselves (or enqueueing it
 themselves). If people complain, we can make it a dependency of 'common'
 as well.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21692#comment:10>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list