[wp-trac] [WordPress Trac] #21688: Add sanity checks and improve performance when searching for posts

WordPress Trac wp-trac at lists.automattic.com
Sun Aug 26 05:29:46 UTC 2012


#21688: Add sanity checks and improve performance when searching for posts
-------------------------+------------------------------
 Reporter:  azaozz       |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Query        |     Version:
 Severity:  normal       |  Resolution:
 Keywords:               |
-------------------------+------------------------------

Comment (by toscho):

 Replying to [comment:9 azaozz]:

 Looks good. I think this comment could be more clear:

 {{{
 // (some browsers won't send more than 2000 characters incl. the URL in a
 urlencoded GET request).
 }}}

 `$q['s']` is already urldecoded when it is counted here. Maybe the comment
 should say ''2000 bytes?''

 Even that is sometimes wrong when
 [http://www.php.net/manual/en/mbstring.overload.php
 mbstring.func_overload] is > 1 and `strlen()` acts like `mb_strlen()` …
 but that’s an edge case and probably not important.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21688#comment:10>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list