[wp-trac] [WordPress Trac] #21616: add-textdomain doesn't conform to WP coding standards

WordPress Trac wp-trac at lists.automattic.com
Fri Aug 17 04:15:30 UTC 2012


#21616: add-textdomain doesn't conform to WP coding standards
--------------------------+----------------------------
 Reporter:  groovecoder   |       Owner:
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  WordPress.org
Component:  I18N          |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+----------------------------
Changes (by dd32):

 * status:  closed => reopened
 * resolution:  invalid =>
 * milestone:   => WordPress.org


Comment:

 > 1) The add-textdomain.php file is not in the WP Core repository, so
 posting a patch for it on this trac is not appropriate.

 As the i18n trac has never been used, I don't see anything wrong with
 having that on the core trac.

 > 2) Patches that only fix coding standards violations are frowned upon,
 since they cause code churn, without much to show for it.

 The changes proposed is in a script which alters existing files, the
 result of the script does not match the WordPress.org coding standards, as
 such, It's not just adding a missing space to an existing script.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21616#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list