[wp-trac] [WordPress Trac] #21562: Twenty Twelve: Hide the "Show navigation" button when there is no navigation to show.

WordPress Trac wp-trac at lists.automattic.com
Wed Aug 15 21:26:36 UTC 2012


#21562: Twenty Twelve: Hide the "Show navigation" button when there is no
navigation to show.
---------------------------+------------------
 Reporter:  cfinke         |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  3.5
Component:  Bundled Theme  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |
---------------------------+------------------

Comment (by lancewillett):

 @obenland One thing I noticed right away -- the small menu styles are
 broken. Previously since the class changed to "main-small-navigation" the
 smaller menu did not inherit and need to override any of the "main-
 navigation" styles.

 Small menu is lowercase, underlined, much less space in between, centered,
 and no sub-level menus at all (just top level).

 It's all doable, just makes the small menu CSS rules a bit more complex
 since they have to override the larger styles. Which brings up something
 -- this theme is all mobile first, so we should really do it backward from
 this:

 1. Outside media queries put small menu styles
 2. Inside min-width of 600px put the larger menu styles

 That takes care of the overrides and also works with how Drew built the
 stylesheet.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21562#comment:11>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list