[wp-trac] [WordPress Trac] #21562: Twenty Twelve: Hide the "Show navigation" button when there is no navigation to show.

WordPress Trac wp-trac at lists.automattic.com
Wed Aug 15 05:43:06 UTC 2012


#21562: Twenty Twelve: Hide the "Show navigation" button when there is no
navigation to show.
---------------------------+------------------
 Reporter:  cfinke         |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  3.5
Component:  Bundled Theme  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |
---------------------------+------------------
Changes (by lancewillett):

 * severity:  minor => normal
 * milestone:  Awaiting Review => 3.5


Comment:

 Replying to [comment:5 obenland]:

 I think going with cfinke's patch will work short-term. Just making sure
 the button isn't there. Yes, the empty menu assigned case is possible, but
 so is someone forking the theme and not showing a menu output at all (or a
 plugin doing that for some reason).

 So the JS fix makes sense to avoid showing the button.

 Let's wait until #21576 is fixed until worrying about the extra markup in
 the source.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21562#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list