[wp-trac] [WordPress Trac] #21553: Remove dupe/deprecated code from sites.php

WordPress Trac wp-trac at lists.automattic.com
Sun Aug 12 00:24:10 UTC 2012


#21553: Remove dupe/deprecated code from sites.php
----------------------------+-----------------------------
 Reporter:  wonderboymusic  |      Owner:
     Type:  enhancement     |     Status:  new
 Priority:  normal          |  Milestone:  Awaiting Review
Component:  Multisite       |    Version:  3.0
 Severity:  normal          |   Keywords:  has-patch
----------------------------+-----------------------------
 {{{current_user_can( 'manage_sites' )}}} is called at the top of
 {{{sites.php}}}, so it doesn't need to be present in every single
 {{{case}}} in the {{{switch}}} statement.

 The "updated" message is currently being output in the middle of an H2, I
 moved that below it.

 The form handler is looking at every action and then passing a different
 action to the redirect that is only read by the message {{{switch}}}
 statement. This is weird, so I moved the action name to the "updated"
 query arg, since updated having a value is the same thing as
 {{{updated=true&action=non-colliding-name}}}.

 There is no row action for {{{matureblog}}} and {{{unmatureblog}}} (I
 scanned the whole codebase), so I removed them.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21553>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list