[wp-trac] [WordPress Trac] #17168: redirect loop when accessing wp-admin/network/

WordPress Trac wp-trac at lists.automattic.com
Fri Aug 10 06:31:44 UTC 2012


#17168: redirect loop when accessing wp-admin/network/
-------------------------------------+------------------------------
 Reporter:  chaos1                   |       Owner:
     Type:  defect (bug)             |      Status:  reopened
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Multisite                |     Version:  3.1.1
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+------------------------------

Comment (by tobias):

 Replying to [comment:16 wpmuguru]:
 > DOMAIN_CURRENT_SITE is not a required constant. Old MU installs will not
 have it nor will installs that are running more than one network.

 Why not introduce a new variable that is used for generating site-urls all
 over the core. And of course there needs to be a fallback for when the
 variable is not set. This fallback may very well be the HTTP_HOST
 variable. But this way there is only one place that needs fixing and it is
 easier to find.

 I was could not really believe when I saw, that the wordpress-core has
 places where a site-url is generated all over the place. I am a little
 impressed that WP managed to manage so much redundancy (not DRY-ness). But
 I don't think it is good.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/17168#comment:17>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list