[wp-trac] [WordPress Trac] #11717: Access to automatic database repair/optimize with admin rights

WordPress Trac wp-trac at lists.automattic.com
Wed Aug 8 08:52:03 UTC 2012


#11717: Access to automatic database repair/optimize with admin rights
-----------------------------------+-----------------------------
 Reporter:  neoxx                  |       Owner:  ryan
     Type:  enhancement            |      Status:  new
 Priority:  normal                 |   Milestone:  Future Release
Component:  Database               |     Version:  2.9.1
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+-----------------------------
Changes (by nacin):

 * keywords:  repair, db, has-patch => has-patch 2nd-opinion


Comment:

 Seems somewhat okay to me to allow repair if is_super_admin(). Obviously,
 that check will fail if the database is unavailable. But if enough tables
 are available (users, usermeta, and potentially options), then it's a nice
 little enhancement, particularly to allow for optimizes without the need
 to trigger a repair.

 That said, we should allow `WP_ALLOW_REPAIR` to be false and prevent the
 script from running in this case.

 I'm also okay with denying this implicit cap check (thus requiring
 WP_ALLOW_REPAIR) if DO_NOT_UPGRADE_GLOBAL_TABLES is set. Also potentially
 multisite in general.

 Eh. I'm kind of okay with a wontfix, rather than conflating DB admin and
 site admin roles unreasonably.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11717#comment:10>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list