[wp-trac] [WordPress Trac] #20487: Comment search isn't customizable

[WordPress Trac]

#20487: Comment search isn't customizable
-----------------------------------+------------------------------
 Reporter:  brokentone             |       Owner:
     Type:  enhancement            |      Status:  new
 Priority:  normal                 |   Milestone:  Awaiting Review
Component:  Comments               |     Version:  3.2.1
 Severity:  normal                 |  Resolution:
 Keywords:  needs-patch has-patch  |
-----------------------------------+------------------------------
Changes (by brokentone):

 * keywords:  needs-patch => needs-patch has-patch


Comment:

 @scribu Thanks for the quick response. Your work on #15032 is impressive.
 I'm sad that didn't make it into core. If you ever want to revisit it, I
 would be interested in helping.

 I was a little unclear, there are no actions/filters between the creation
 and execution of the mysql query. I'm looking into how it is setup in
 story searching and I'll create similar behavior here.

 In the meantime I diffed my changes for review. I understand your argument
 against them, and if I'm only able to get the filter to core, I'll indeed
 be able to do what I need as a plugin, but I still propose at least the
 underlying logic still be included in core for the following reasons:
 1. This is a scalability problem. It *works*, albeit inefficiently, on
 small sites, but by the time you have millions of comments (yes, multiple
 millions) it does not. 16 second queries are impossible to make work. I
 understand WP is attempting to be a serious player in large-scale
 websites, to not address this issue in core would be to ignore large-scale
 players' needs.
 2. The increased functionality adds little complexity.
 3. Current functionality is broken. When an admin clicks on the IP address
 of a comment, the logical outcome would be to do an exact search on only
 the comment_author_IP field. The expectation would not be to look for the
 IP as a string within author emails, comment text, etc. Having the
 functionality in the objects can allow this logical outcome even without
 an advanced search form.
 4. It will be difficult to design a plugin to have a similar UX without
 greater core support. I would have to create a separate page to host the
 advanced search form, then I believe I would have to direct the action of
 that form to the existing comment display page, where the current search
 form will be appear as there is no hook there to remove or modify it.

 I appreciate your consideration,
 -Kenton Jacobsen
 theblaze.com

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20487#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software