[wp-trac] [WordPress Trac] #18991: Unnecessarily cryptic code when checking pagename= for verbose rules

WordPress Trac wp-trac at lists.automattic.com
Wed Oct 19 22:45:06 UTC 2011


#18991: Unnecessarily cryptic code when checking pagename= for verbose rules
---------------------------+------------------
 Reporter:  duck_          |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  3.3
Component:  Rewrite Rules  |     Version:  3.3
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |
---------------------------+------------------
Changes (by nacin):

 * component:  General => Rewrite Rules


Comment:

 Per WP_MatchesMapRegex's $_pattern: `'(\$matches\[[1-9]+[0-9]*\])'`. Seems
 like the `[1-9]+[0-9]*` should also venture into these regexes.

 Looks good otherwise. If it's not $matches, it won't work.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18991#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list