[wp-trac] [WordPress Trac] #18785: Modernize screen functions

WordPress Trac wp-trac at lists.automattic.com
Tue Oct 11 21:29:36 UTC 2011


#18785: Modernize screen functions
----------------------------+-----------------------
 Reporter:  nacin           |       Owner:  nacin
     Type:  task (blessed)  |      Status:  assigned
 Priority:  normal          |   Milestone:  3.3
Component:  Administration  |     Version:  3.3
 Severity:  normal          |  Resolution:
 Keywords:  needs-patch     |
----------------------------+-----------------------
Changes (by nacin):

 * type:  enhancement => task (blessed)
 * milestone:  Awaiting Review => 3.3


Comment:

 [attachment:18785.diff] reworks how WP_Screen stores data. Everything ends
 up in private and static variables. Keeps full compatibility and since
 everything is encapsulated, we can optionally create a formal factory
 later.

 convert_to_screen() can return a new WP_Screen object now, even for the
 current screen's ID. Data does not die when a reference to an object is
 gone.

 The global in get_column_headers() is now just a static.
 $_wp_contextual_help is gone now too, though the back compat filters
 remain. It is now WP_Screen::$_old_compat_help.

 There's some more cleanup to be had here, but it's in good shape. If
 anyone else has something to propose, please provide a patch and comment.
 Thanks.

 I intend to close this as fixed before beta 2.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18785#comment:48>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list