[wp-trac] [WordPress Trac] #18197: The admin bar should blend in better with the new UI

WordPress Trac wp-trac at lists.automattic.com
Mon Oct 10 20:33:07 UTC 2011


#18197: The admin bar should blend in better with the new UI
----------------------------+--------------------------
 Reporter:  nacin           |       Owner:  koopersmith
     Type:  task (blessed)  |      Status:  accepted
 Priority:  normal          |   Milestone:  3.3
Component:  UI              |     Version:  3.3
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |
----------------------------+--------------------------

Comment (by nacin):

 [18929] is only temporary, pending testing. If it lasts, we will indeed
 need a better way to do it, code-wise.

 I was thinking we could possibly leverage wp-admin/menu.php, but we'll
 definitely want to ob_start() and ob_end_clean() before and after, to
 protect us from plugins doing bad things on admin_menu. However, I don't
 think this is safe. If anyone is using a single admin-only core function
 on admin_menu to check something before doing menu-related tasks, it'll
 fatal error. And that wouldn't be our fault.

 We can move most things to wp-includes/menu.php and add a new hook plugins
 can switch to. Then they just need to replace "admin_men" with our new
 hook to get things working automatically in the admin bar.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18197#comment:116>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list