[wp-trac] [WordPress Trac] #15458: Lazy-load usermeta into the user object

WordPress Trac wp-trac at lists.automattic.com
Thu Oct 6 18:19:15 UTC 2011


#15458: Lazy-load usermeta into the user object
----------------------------------------+-----------------------
 Reporter:  nacin                       |       Owner:
     Type:  enhancement                 |      Status:  reopened
 Priority:  normal                      |   Milestone:  3.3
Component:  Performance                 |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |
----------------------------------------+-----------------------
Changes (by ryan):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 wp_update_user() is broken.

 {{{
         // First, get all of the original fields
         $user = WP_User::get_data_by('id', $ID);

         // Escape data pulled from DB.
         $user = add_magic_quotes(get_object_vars($user));
 }}}

 That no longer has the meta values in it, so plugins that pass just the
 things they want to change in $userdata ends up stomping meta values.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/15458#comment:57>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list