[wp-trac] [WordPress Trac] #19385: wp_get_active_network_plugins() can generate a needless query

WordPress Trac wp-trac at lists.automattic.com
Mon Nov 28 20:12:07 UTC 2011


#19385: wp_get_active_network_plugins() can generate a needless query
--------------------------+-----------------
 Reporter:  nacin         |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  3.3
Component:  Multisite     |    Version:  3.3
 Severity:  normal        |   Keywords:
--------------------------+-----------------
 In #18955, we stopped caching the default value when get_site_option() was
 called on an option that does not exist.

 This introduces a situation where active_sitewide_plugins may be queried
 for on every pageload.

  1. active_sitewide_plugins should be instantiated in populate_network()
 and added to upgrade_network().

  2. wp_load_core_site_options() should be set up to cache as false any
 keys it misses. As this only works when an external object cache is not at
 play, it basically becomes a rudimentary not-options cache. (See #19008.)

 Point 1 is for 3.3. Point 2 is a general nice-to-have.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19385>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list