[wp-trac] [WordPress Trac] #19371: As of 3.3beta2 WP_Admin_Bar no longer provides a way to access attributes of existing menu items

WordPress Trac wp-trac at lists.automattic.com
Mon Nov 28 16:54:33 UTC 2011


#19371: As of 3.3beta2 WP_Admin_Bar no longer provides a way to access attributes
of existing menu items
--------------------------+-----------------------
 Reporter:  willshouse    |       Owner:  nacin
     Type:  defect (bug)  |      Status:  accepted
 Priority:  normal        |   Milestone:  3.3
Component:  Admin Bar     |     Version:  3.3
 Severity:  minor         |  Resolution:
 Keywords:  has-patch     |
--------------------------+-----------------------

Comment (by nacin):

 My current thoughts:

  * get_node() should return the node, or false on failure.

  * remove_node() should return get_node() in addition to unsetting.

  * The stuff in 'meta' should be promoted to first-level properties.

  * The late binding code should be moved to a separate protected method,
 rather than being in render.

  * I'm torn on private versus protected. Was leaning toward private for
 the properties, but protected for the render_* methods. Could go with both
 going to protected.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19371#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list