[wp-trac] [WordPress Trac] #19244: get_theme() function incorrectly assuming $themes is always an array

WordPress Trac wp-trac at lists.automattic.com
Mon Nov 14 23:54:51 UTC 2011


#19244: get_theme() function incorrectly assuming $themes is always an array
--------------------------+------------------------------
 Reporter:  cgrymala      |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Themes        |     Version:  3.3
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------------------

Comment (by nacin):

 Simple fix, but note that core never uses get_theme(). Looks like
 get_themes() has been able to return a boolean for a few years now. Feels
 odd, but that's how it (currently) is. But it also looks like a number of
 locations in core might break if get_themes() returned false. We seem to
 be inconsistent in casting.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19244#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list