[wp-trac] [WordPress Trac] #17748: Twenty Eleven code review & consistancy

[WordPress Trac]

#17748: Twenty Eleven code review & consistancy
---------------------------+-----------------------
 Reporter:  dd32           |       Owner:  azaozz
     Type:  defect (bug)   |      Status:  reopened
 Priority:  normal         |   Milestone:  3.2
Component:  Bundled Theme  |     Version:  3.2
 Severity:  normal         |  Resolution:
 Keywords:                 |
---------------------------+-----------------------

Comment (by dd32):

 Summery of pending changes here:
  * Coding - Theme has to check {{{get_option('page_comments')}}} in order
 to determine if comment paging is enabled as get_comment_pages_count()
 returns > 1 when paging is disabled. See #17778
  * String change - s/<b>/<strong>/g ? comment:3
  * String change - CPT & Categories missing from their "posted in" line,
 comment:20
  * UI - Image Post Format footer style, comment:18 features a different
 style and colour: [http://dd32.id.au/files/wordpress/temp/2011--
 footercolourstyle.jpg 2011--footercolourstyle.jpg]
    * Background Colour
    * Date in the footer for the image, Posted In & Leave reply have a
 separator on other types, here, it's a new line
    * Has Different Link colour in order to fit in with background colour
    * Edit link can probably float on the same line even
  * UI - Status/Aside title vs. content mis-matches in different places
 comment:1 comment:2
  * CSS/UI - Comment reply button is not aligned consistantly, comment:11
 [http://dd32.id.au/files/wordpress/temp/2011-commentreplymisaligned.jpg
 2011-commentreplymisaligned.jpg]

 If other devs can weigh in here on their expected/preferred outcome on
 those points, it'd be appreciated as I'm not too fussed about which way
 they all go, The UI ones just don't feel right to me, but that's not my
 area of expertise :) (''Just ship it! '' isn't what i'd like to hear
 either ;))

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/17748#comment:25>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software