[wp-trac] [WordPress Trac] #16026: Stop using ereg() and eregi()

WordPress Trac wp-trac at lists.automattic.com
Sat Apr 23 23:59:46 UTC 2011


#16026: Stop using ereg() and eregi()
-------------------------------------+-----------------------------
 Reporter:  NorwayFun                |       Owner:  NorwayFun
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  Future Release
Component:  External Libraries       |     Version:
 Severity:  minor                    |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+-----------------------------
Changes (by dd32):

 * keywords:  has-patch dev-feedback 2nd-opinion needs-testing => has-patch
     needs-testing


Comment:

 In both patches, the closing delimiter of wp-admin/includes/class-ftp-
 pure.php is wrong (in the wrong string)

 and in .2 the function change looks ok, but it wasn't updated in the spot
 where it was called.

 my string comparison remark was mainly related to the changes in wp-
 includes/class-pop3.php it seems after re-reading the patch.

 I'd go with the s/eregi/preg_*/g approach, all the individual regex's just
 need to be tested properly.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16026#comment:10>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list