[wp-trac] [WordPress Trac] #16606: WP_Http_Streams::test doesn't check enough to confirm if it can do HTTPS

[WordPress Trac]

#16606: WP_Http_Streams::test doesn't check enough to confirm if it can do HTTPS
---------------------------------+-----------------------------
 Reporter:  westi                |       Owner:
     Type:  defect (bug)         |      Status:  new
 Priority:  high                 |   Milestone:  Future Release
Component:  HTTP                 |     Version:  3.0.5
 Severity:  major                |  Resolution:
 Keywords:  3.2-early has-patch  |
---------------------------------+-----------------------------

Comment (by hakre):

 [attachment:16606.6.patch 16606.6.patch] containted the $scheme check in
 each concrete ::test() function.

 In [attachment:16606.7.patch 16606.7.patch] I reduced the code now by only
 checking the $scheme where applicable (only Streams so far). Next to that
 there were some minor formatting / comment / coding issues in
 [attachment:16606.6.patch 16606.6.patch] I fixed in this new patch.

 The WP_Http_ExtHttp::test() function was lacking check of request and SSL
 support. The WP_Http_ExtHttp::request() made use of http_inflate which is
 only available if the http extension supports encodings.

 Looks like that now each of the four WP_Http_Concrete::test() is checking
 for SSL support for the first time.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16606#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software