[wp-trac] [WordPress Trac] #14976: WP_Query's init() and init_query_flags() do not do thorough resets

WordPress Trac wp-trac at lists.automattic.com
Wed Sep 29 14:28:02 UTC 2010


#14976: WP_Query's init() and init_query_flags() do not do thorough resets
------------------------------------+---------------------------------------
 Reporter:  coffee2code             |        Owner:        
     Type:  defect (bug)            |       Status:  closed
 Priority:  normal                  |    Milestone:  3.1   
Component:  Query                   |      Version:  3.0.1 
 Severity:  minor                   |   Resolution:  fixed 
 Keywords:  has-patch dev-feedback  |  
------------------------------------+---------------------------------------
Changes (by hakre):

  * keywords:  has-patch => has-patch dev-feedback


Comment:

 I suggest an additional init_something subroutine for those values
 directly reset in init() to easier understand the init function.

 Next to that I assume that it's not wanted to unset public properties but
 to set them to null or better to say, their default value. Unsetting the
 properties means to remove them from the class which I assume is not
 intended.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/14976#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list