[wp-trac] [WordPress Trac] #14837: Themes should allow custom headers to be selectable, but not uploadable

WordPress Trac wp-trac at lists.automattic.com
Fri Sep 17 17:16:32 UTC 2010


#14837: Themes should allow custom headers to be selectable, but not uploadable
-------------------------+--------------------------------------------------
 Reporter:  jorbin       |       Owner:  jorbin   
     Type:  enhancement  |      Status:  accepted 
 Priority:  normal       |   Milestone:  3.1      
Component:  Themes       |     Version:           
 Severity:  minor        |    Keywords:  has-patch
-------------------------+--------------------------------------------------

Comment(by kahless):

 Replying to [comment:3 jorbin]:
 > Replying to [comment:2 nacin]:
 > > Possible better way of implementing this: We should instead register
 theme support for "custom-header-uploads" by default, and allow the theme
 to remove said theme support as a way to enable this.
 > >
 >
 > That makes sense.  I'll update the patch accordingly.
 >
 > > Replying to [comment:1 ericmann]:
 > > > Honestly, if a theme doesn't want to support the uploading of custom
 headers, that's up to the theme ... why does this patch need to be in
 core?  I don't see the point.
 >
 > Exactly, it should be up to the theme.  Right now it's not even an
 option.  Custom headers are all or nothing.
 >
 > >
 > > Because the theme would still want the ability for registered headers
 to be chosen. Currently the custom-header UI won't support that.
 > >
 > > I see use cases here for sure. Not a good idea for a distributed
 theme, but rather in instances where a user on a site might be allowed to
 edit_theme_options but should not be allowed to modify anything beyond
 what the admins have specifically set up for the site.
 >
 > Another use case I see is being on Multi Site networks that want to
 offer a range of branded headers, but not wanting to give the user the
 option to upload an unbranded one.
 >
 This is exactly the situation in which I find myself. I am designing a
 faculty research showcase and one of the things we want is to allow each
 faculty member to be able to customize their research site's look to some
 degree, but remain within the branding and marketing of the college. We
 will be in a multisite setting where the main site will have a custom
 theme and I'd like to use Twenty Ten as the theme on each faculty research
 site where they can choose from the header images we provide.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/14837#comment:10>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list