[wp-trac] [WordPress Trac] #14859: WP-DB Add query_done Action for Performance Logging Plugins

WordPress Trac wp-trac at lists.automattic.com
Tue Sep 14 01:00:34 UTC 2010

#14859: WP-DB Add query_done Action for Performance Logging Plugins
 Reporter:  sexytyranno  |       Owner:                 
     Type:  enhancement  |      Status:  new            
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Database     |     Version:  3.0.1          
 Severity:  normal       |    Keywords:                 

Comment(by sexytyranno):

 The newly create action will only actually work when SAVEQUERIES is
 define()d, so on most production sites using sane plug-ins, shouldn't
 cause any performance impact.

 Really, I've not ever seen SAVEQUERIES defined before, except in the
 context of debugging issues, so the impact should be pretty narrowed.

 If the core WP group would prefer, we could also add another low-publicity
 define() into wp-config.php to enable the query_done action, so as to make
 it one of those things where a site administrator would have manually and
 knowingly enable it.

 To this extent, perhaps we can insert a warning near the top of wp-admin
 somewhere outlining that:

 - It's enabled. It's typically defined in wp-config.php, but it may be
 defined in a plug-in or theme. (Silly and bad plug-in/theme author!)

 - Debugging only feature. Should not be used on live sites.

 - Possible performance impact while it's enabled.

 Some of the above may be ported to a "What does this mean?" link, rather
 than having a really large warning box.

Ticket URL: <http://core.trac.wordpress.org/ticket/14859#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software

More information about the wp-trac mailing list