[wp-trac] [WordPress Trac] #14786: WP_Http Transport test order refactoring

WordPress Trac wp-trac at lists.automattic.com
Mon Sep 6 18:40:24 UTC 2010

#14786: WP_Http Transport test order refactoring
 Reporter:  hakre         |       Owner:                        
     Type:  defect (bug)  |      Status:  new                   
 Priority:  normal        |   Milestone:  Awaiting Review       
Component:  HTTP          |     Version:  3.0.1                 
 Severity:  normal        |    Keywords:  has-patch dev-feedback

Comment(by jacobsantos):

 Replying to [comment:15 hakre]:
 >  * The design limitations as discussed in #11613 are not dealt with so
 far. But The changes so far should make it more easily to add such a

 I believe the solution in that ticket, should fix the problems. I think
 too much is being relied on with the test() method, which should be
 revisited to not be as used as much as it is now. The test() method was
 only ever supposed to be used as to whether the transport was supported by
 the PHP version and whether the extension was installed.

 Using it as a means to whether the transport supports SSL is wrong. They
 should all support SSL provided openSSL extension is installed and barring
 any PHP specific bugs. Also, the fear with some of the checks, for example
 nonblocking, is that so few of the transport supports nonblocking that you
 limit which transport will be used.

 Also, given that also some transports like cURL aren't written to support
 nonblocking correctly it adds additional complexity to adding it.

Ticket URL: <http://core.trac.wordpress.org/ticket/14786#comment:17>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software

More information about the wp-trac mailing list