[wp-trac] [WordPress Trac] #14227: wp_login_form remember input / label mixed

WordPress Trac wp-trac at lists.automattic.com
Thu Oct 28 06:51:10 UTC 2010


#14227: wp_login_form remember input / label mixed
--------------------------+-------------------------------------------------
 Reporter:  chocks        |       Owner:                   
     Type:  defect (bug)  |      Status:  new              
 Priority:  normal        |   Milestone:  Awaiting Review  
Component:  Formatting    |     Version:  3.0              
 Severity:  normal        |    Keywords:  2nd-opinion close
--------------------------+-------------------------------------------------
Changes (by nacin):

  * keywords:  wp_login_form gsoc has-patch needs-testing => 2nd-opinion
               close


Comment:

 What is this fixing?

 It looks like all it is doing is switching the checkbox and the text.

 Additionally the patch breaks the label association with the checkboxes.
 Labels either have to be linked to inputs with the 'for' attribute, or
 they need to wrap the input. (Which is why it wrapped it originally.)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/14227#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list