[wp-trac] [WordPress Trac] #14053: Weird, and seemingly incorrect, classes on menu items

WordPress Trac wp-trac at lists.automattic.com
Tue Jun 22 22:09:22 UTC 2010


#14053: Weird, and seemingly incorrect, classes on menu items
--------------------------+-------------------------------------------------
 Reporter:  nathanrice    |       Owner:           
     Type:  defect (bug)  |      Status:  new      
 Priority:  normal        |   Milestone:  3.0.1    
Component:  Menus         |     Version:  3.0      
 Severity:  normal        |    Keywords:  has-patch
--------------------------+-------------------------------------------------

Comment(by nathanrice):

 Replying to [comment:1 filosofo]:
 > ` fix-menu-item-home-class.14053.diff` should fix the home-link class
 issue. Good catch.
 >
 > I think the idea behind using `menu-item-type-post_type` is that now
 it's increasingly likely for there to be unexpected post types; hence the
 more general class can apply styling rules to unanticipated menu items.

 I agree, if this was an unknown post-type. But this is a page. Shouldn't
 it be `menu-item-type-page`?

 Also, if I need to create other tickets for the issues other than the home
 class, let me know. I didn't really think that through when I created this
 ticket.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/14053#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list