[wp-trac] [WordPress Trac] #14049: Upgrade takes an hour to complete due to repeated 30-second FTP timeout

WordPress Trac wp-trac at lists.automattic.com
Tue Jun 22 17:59:38 UTC 2010


#14049: Upgrade takes an hour to complete due to repeated 30-second FTP timeout
-----------------------------+----------------------------------------------
 Reporter:  mmorearty        |       Owner:            
     Type:  defect (bug)     |      Status:  new       
 Priority:  normal           |   Milestone:  Unassigned
Component:  Upgrade/Install  |     Version:            
 Severity:  normal           |    Keywords:            
-----------------------------+----------------------------------------------

Comment(by mmorearty):

 Note the explicit check for error code 426 in function abort() in wp-
 admin/includes/class-ftp.php:

 {{{
 function abort() {
     if(!$this->_exec("ABOR", "abort")) return FALSE;
     if(!$this->_checkCode()) {
         if($this->_code!=426) return FALSE;
         if(!$this->_readmsg("abort")) return FALSE;
         if(!$this->_checkCode()) return FALSE;
     }
     return true;
 }
 }}}

 The way this is written, if ABOR returns any error code ''other'' than
 426, abort() just returns FALSE; but if it sees 426, it tries to read one
 more line (the call to _readmsg()) before returning FALSE.  On my FreeBSD
 machine, though, there is nothing more to read.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/14049#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list