[wp-trac] [WordPress Trac] #12812: New Nav Menu needs to have ancestor class

[WordPress Trac]

#12812: New Nav Menu needs to have ancestor class
-------------------------+--------------------------------------------------
 Reporter:  joostdevalk  |        Owner:  filosofo
     Type:  enhancement  |       Status:  closed  
 Priority:  normal       |    Milestone:  3.0     
Component:  Menus        |      Version:  3.0     
 Severity:  blocker      |   Resolution:  fixed   
 Keywords:  has-patch    |  
-------------------------+--------------------------------------------------

Comment(by filosofo):

 Replying to [comment:32 ryanhellyer]:
 > However ... the parent of that Page, regardless of whether the parent is
 in fact it's "Page parent", is given the class of "current_page_parent" as
 well as the expected "current-menu-parent". Since it isn't actually the
 current pages parent and is just a parent in the menu, it shouldn't be
 given the "current_page_parent" class IMO.

 This was done deliberately to be backwards-compatible with `wp_page_menu`
 styling.

 > Then it gets really bizarre, as the actual top level page ancestor,
 regardless of where it is in the menu structure, is given a class of
 "current-menu-ancestor" despite not being an ancestor within the menu
 structure

 That does sounds like a bug.  I'll investigate.

 > and also classes of "current-page-parent" (expected) and
 "current_page_ancestor" (unexpected).

 Why is `current_page_ancestor` unexpected?  Isn't it the current page's
 ancestor?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/12812#comment:33>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software