[wp-trac] [WordPress Trac] #13830: Front page displays: Fix same static page warning

WordPress Trac wp-trac at lists.automattic.com
Fri Jun 11 06:07:29 UTC 2010


#13830: Front page displays: Fix same static page warning
----------------------------+-----------------------------------------------
 Reporter:  zeo             |       Owner:                  
     Type:  defect (bug)    |      Status:  new             
 Priority:  normal          |   Milestone:  3.0             
Component:  Administration  |     Version:  3.0             
 Severity:  normal          |    Keywords:  has-patch commit
----------------------------+-----------------------------------------------
Changes (by nacin):

  * keywords:  has-patch => has-patch commit


Comment:

 Attached diff takes zeo's patch a bit further.

 The reason why no warning showed up in the admin was because only one was
 getting sanitized as an integer. Since we're now going to use
 show_option_none => 0, sanitizing it won't help any, but since I caught
 it, we might as well also sanitize it (a review we need to do in a future
 release more thoroughly).

 I also added a little code to catch bad values and fix them when showing
 options-reading (thus after saving). It does it silently, but I think that
 is perfectly acceptable for now.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/13830#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list