[wp-trac] [WordPress Trac] #12372: Remove Archaic get_children() reference returns

[WordPress Trac]

#12372: Remove Archaic get_children() reference returns
--------------------------+-------------------------------------------------
 Reporter:  filosofo      |       Owner:  ryan                            
     Type:  defect (bug)  |      Status:  new                             
 Priority:  normal        |   Milestone:  3.0                             
Component:  General       |     Version:  3.0                             
 Severity:  normal        |    Keywords:  get_children reference has-patch
--------------------------+-------------------------------------------------
 It appears from r03321 that the children objects variable returned by
 `get_children` originally was meant to be bound by reference to the posts
 object cache.

 However, currently `get_children` passes its objects to
 `update_post_cache` which in turn iterates over them ''not by reference''
 with `wp_cache_add`.  So the reference is no longer to the cache.

 Besides, aside from the new twentyten theme, nowhere else in core does a
 variable get bound to that returned by `get_children`.  So patch removes
 `get_children`'s reference syntax.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/12372>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software