[wp-trac] [WordPress Trac] #12334: A series of typos/thinkos that should be fixed

WordPress Trac wp-trac at lists.automattic.com
Mon Feb 22 17:22:41 UTC 2010


#12334: A series of typos/thinkos that should be fixed
--------------------------+-------------------------------------------------
 Reporter:  rlerdorf      |       Owner:            
     Type:  defect (bug)  |      Status:  new       
 Priority:  low           |   Milestone:  Unassigned
Component:  General       |     Version:            
 Severity:  normal        |    Keywords:            
--------------------------+-------------------------------------------------
 In wp-includes/capabilities.php around line 773:

 $cap_key = $wpdb->get_blog_prefix( $blog_id );
 $cap_key. 'capabilities';

 The author probably meant .= here.

 In wp-admin/import/blogger.php around line 168:

 } elseif ( $tag['tag'] == 'SUMMARY' ) {
         $blog['summary'] == $tag['value'];

 The == on the second line there should obviously be just a single =

 In wp-admin/includes/user.php around line 835:

 function default_password_nag_edit_user($user_ID, $old_data) {
         global $user_ID;

 The author overwrites the passed in $user_ID argument with the global
 version right away.  This makes very little sense.  Choose one or the
 other.

 In wp-includes/class-simplepie.php around line 4070(!!) there are 3 lines
 of code that don't make sense:

 (int) $seconds = array_pop($temp);
 (int) $minutes = array_pop($temp);
 (int) $hours = array_pop($temp);

 Those casts don't do anything.  The author probably meant to put the cast
 on the right hand side perhaps?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/12334>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list