[wp-trac] [WordPress Trac] #9015: New theme for 3.0 -- Twenty Ten

WordPress Trac wp-trac at lists.automattic.com
Tue Feb 16 08:18:14 UTC 2010


#9015: New theme for 3.0 -- Twenty Ten
----------------------------+-----------------------------------------------
 Reporter:  dd32            |       Owner:     
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  3.0
Component:  Themes          |     Version:     
 Severity:  normal          |    Keywords:     
----------------------------+-----------------------------------------------

Comment(by dd32):

 Some patch feedback:

 > more-more-functions.php-patch.diff - All page titles are now consistent
 with a new twentyten_page_title() function which is filterable. Wrapped
 page links into a filterable function too.

 I dont think moving everything out of the template files and into
 functions is in the best interst of users, Theres nothing wrong with
 having template code in a template.

 > Use the API for CSS and JS, wrapped the header background image into a
 function

 Hadnt seen that one, Once again, I dont think its a smart move to move
 things out of the header to a function. I dont have anything against using
 the CSS API properly.. But would prefer to leave that up to someone else,
 It could be a bit confusing for some.

 That would also mean that the stylesheets would be included in child
 themes too.. Potentially, its best left in the header file again.

 > Please add a valid page template to this theme, or the forums will be
 slammed with the question "Where's the Template option when I'm writing a
 page?"

 I agree with this, What are some -Useful- templates which we could add to
 the theme?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/9015#comment:112>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list