[wp-trac] [WordPress Trac] #13066: Last-Modified headers for individual comment feeds are incorrect

WordPress Trac wp-trac at lists.automattic.com
Sat Apr 24 03:33:49 UTC 2010


#13066: Last-Modified headers for individual comment feeds are incorrect
--------------------------+-------------------------------------------------
 Reporter:  solarissmoke  |       Owner:                
     Type:  defect (bug)  |      Status:  new           
 Priority:  low           |   Milestone:  Future Release
Component:  Feeds         |     Version:  3.0           
 Severity:  normal        |    Keywords:  dev-feedback  
--------------------------+-------------------------------------------------
Changes (by dd32):

  * milestone:  3.0 => Future Release


Comment:

 This code is run early in the execution of WordPress, At the point in time
 its run, All WordPress knows is, that its a query for a Comments feed.

 Its a trade off between bandwidth and server load, continuing to process
 the request will require loading the rest of WordPress & parsing the
 request & database fetches. all of which, would be pointless if no
 comments have been posted.

 At the same time, it wastes bandwidth in preference to wasting CPU cycles
 as feeds are re-served often when they're not needed to.

 Theres a few options here:
  * Leave as-is
  * Make the code here run AFTER posts are queried, which would result in
 higher CPU load, yet more accurate result
  * Make the comment check specify the post for the requests using a manual
 SQL
    * for p, page_id, and attachment_id requests, this wouldnt require an
 extra SQL
    * for name and attachment requests, this would require an extra SQL
 query
    * for pagename requests, this would probably require a few more queries

 Since this isnt a regression(and we're trying to get 3.0 done), I'm
 setting this to Future Release pending agreement and/or a patch.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/13066#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list