[wp-trac] [WordPress Trac] #12506: admin-color-scheme.css already loaded on wp-login.php. why?

WordPress Trac wp-trac at lists.automattic.com
Sun Apr 18 22:37:03 UTC 2010


#12506: admin-color-scheme.css already loaded on wp-login.php. why?
----------------------------+-----------------------------------------------
 Reporter:  F J Kaiser      |        Owner:                
     Type:  enhancement     |       Status:  closed        
 Priority:  low             |    Milestone:  Future Release
Component:  Administration  |      Version:  2.9.2         
 Severity:  minor           |   Resolution:  fixed         
 Keywords:  needs-patch     |  
----------------------------+-----------------------------------------------

Comment(by F J Kaiser):

 The new patch works in my test-scenario as expected.

 Description of what i did, so other contributers can understand my patch
 easier:
 * I added 3 classes for messages: .plugin-message, .plugin-message-yellow,
 .plugin-message-error. Those are there, so plugin code can be marked
 easier and the wp-login.php should be a bit easier readable in the
 sourcecode.
 * Changed the vertical-alignment of the #backtoblog link.
 * Reordered all code, so the file is (hopefully) even in the compressed
 version easier search and readable. For ex.: padding-top: 3px; padding-
 bottom: 5px; padding-left: 9px; > padding: 3px 0 5px 9px; and so on. Same
 to font, border, margin. Further the file now has with all IDs/classes the
 same order at the definitions.

 Sidenotes about furter enchancements for wp-login.php:
 * I was looking at all the <p>-tags for messages and links. But when i
 tried the error-handling i found the error-messages sitting in a
 <div>-tag. I would prefer divs or spans for all messages. In my test-
 scenarion there was no change, because i targeted most stuff at their
 class and not the html-tag. Divs and spans offer more possibilities than
 Paragraph tags. I think the Paragraphes should all get Divs or spans.
 * The error-message is the only message i found, that has an ID instead of
 a class. Other error-messages for plugins are that way impossible. I tried
 to get around that too with the plugin-* classes. Other ideas are welcome.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/12506#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list