[wp-trac] [WordPress Trac] #11836: Clean up register_sidebar(s) functions

WordPress Trac wp-trac at lists.automattic.com
Tue Apr 6 17:12:52 UTC 2010


#11836: Clean up register_sidebar(s) functions
--------------------------+-------------------------------------------------
 Reporter:  scribu        |       Owner:  azaozz                                   
     Type:  defect (bug)  |      Status:  new                                      
 Priority:  normal        |   Milestone:  3.0                                      
Component:  Widgets       |     Version:                                           
 Severity:  normal        |    Keywords:  has-patch needs-refresh reporter-feedback
--------------------------+-------------------------------------------------
Changes (by nacin):

  * keywords:  has-patch commit => has-patch needs-refresh reporter-
               feedback


Comment:

 I've looked at this a few times and can't help but notice that you removed
 {{{$_args['id'] = $args['id'];}}} as if it was {{{$args['id'] =
 $args['id'];}}}. I imagine that's a mistake?

 Also, patch is now stale -- looks like that code has changed.

 Second hunk looks okay though.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11836#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list