[wp-trac] [WordPress Trac] #10077: clean_url improperly scrapes %20

WordPress Trac wp-trac at lists.automattic.com
Sat Nov 14 05:17:55 UTC 2009


#10077: clean_url improperly scrapes %20
----------------------------------------+-----------------------------------
 Reporter:  noel                        |        Owner:  ryan   
     Type:  defect (bug)                |       Status:  closed 
 Priority:  high                        |    Milestone:  2.9    
Component:  Formatting                  |      Version:  2.8    
 Severity:  major                       |   Resolution:  invalid
 Keywords:  has-patch needs-unit-tests  |  
----------------------------------------+-----------------------------------
Changes (by miqrogroove):

 * cc: miqrogroove@… (added)
  * status:  reviewing => closed
  * resolution:  => invalid


Comment:

 This is not a bug.  The behavior described by westi is correct.  I have
 reviewed the trunk code, compared it to RFC 1738, and it appears to be
 perfect.  Spaces fall under the definition of Unsafe URL Characters and
 are never allowed to appear unless encoded.

 If there is a cosmetic problem involving URLs that are passed to
 clean_url(), then we should have a ticket describing why and how
 clean_url() is being used at a higher level.

 I don't object to westi's idea for test cases, but this is currently a
 matter of "garbage in, garbage out."

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/10077#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list