[wp-trac] [WordPress Trac] #11426: Allow trash option in comment notification emails

[WordPress Trac]

#11426: Allow trash option in comment notification emails
--------------------------+-------------------------------------------------
 Reporter:  nacin         |       Owner:           
     Type:  defect (bug)  |      Status:  new      
 Priority:  normal        |   Milestone:  2.9      
Component:  Trash         |     Version:  2.9      
 Severity:  normal        |    Keywords:  has-patch
--------------------------+-------------------------------------------------

Comment(by nacin):

 In general, I went as simple as possible with the patch to see to a 2.9
 commit.

 The AYS intention check is necessary because you're coming from e-mail.

 I'm not sure about "Delete Permanently." I suppose it can be changed to
 "Permanently Delete Comment." This patch is already requiring some string
 changes, so it can't hurt.

 mac, cdc, and dt are all artifacts. A few years ago, they stood for
 moderateapprovecomment, confirmdeletecomment, and delete_type.
 Realistically we should convert these to
 action=(approve|delete|trash|spam).

 But since mac/cdc/dt still need to be maintained for back compat
 (particularly since the notify functions are pluggable), I decided against
 it to keep this simple for 2.9.

 I will work up a second patch to clean this up some more. Xref - #11432.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11426#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software