[wp-trac] [WordPress Trac] #11401: checks against array('draft', 'pending') should be changed

WordPress Trac wp-trac at lists.automattic.com
Fri Dec 11 20:46:35 UTC 2009


#11401: checks against array('draft', 'pending') should be changed
-------------------------------+--------------------------------------------
 Reporter:  Denis-de-Bernardy  |       Owner:     
     Type:  defect (bug)       |      Status:  new
 Priority:  normal             |   Milestone:  2.9
Component:  Trash              |     Version:  2.9
 Severity:  normal             |    Keywords:     
-------------------------------+--------------------------------------------

Comment(by nacin):

 Yeah, my initial search string was {{{in_array.*(pending|draft|future)}}},
 which found 23 matches in 10 files. I also found one instance of an or/and
 check, [http://core.trac.wordpress.org/browser/trunk/wp-includes/link-
 template.php#L225 in _get_page_link()].

 I looked through those matches quickly and saw nothing glaring other than
 the two I've pointed out, though a second look couldn't hurt.

 Good catch in the JS.

 This all said, while I agree with hardening, the indirect coverage is
 largely this: many of these instances are inaccessible as a trashed
 post/page returns 404 in the front and wp_die in the admin area.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11401#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list